rzerres/element-call
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove the disablePictureInPicture Firefox hack

Browse Source 
https://bugzilla.mozilla.org/show_bug.cgi?id=1865748 is fixed in Firefox 122.0, so we can now use the attribute the normal way.
This commit is contained in:
Robin
2024-02-01 14:06:53 -05:00
parent 536797820d
commit 0824963811
2 changed files with 2 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/room/VideoPreview.tsx
View File

@@ -114,14 +114,7 @@ export const VideoPreview: FC<Props> = ({
playsInline playsInline
// There's no reason for this to be focusable // There's no reason for this to be focusable
tabIndex={-1} tabIndex={-1}
// React supports the disablePictureInPicture attribute, but Firefox disablePictureInPicture
// only recognizes a value of "true", whereas React sets it to the empty
// string. So we need to bypass React and set it specifically to "true".
// https://bugzilla.mozilla.org/show_bug.cgi?id=1865748
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
// eslint-disable-next-line react/no-unknown-property
disablepictureinpicture="true"
/> />
{!muteStates.video.enabled && ( {!muteStates.video.enabled && (
<div className={styles.avatarContainer}> <div className={styles.avatarContainer}>

9
src/video-grid/VideoTile.tsx
View File

@@ -134,14 +134,7 @@ const Tile = forwardRef<HTMLDivElement, TileProps>(
trackRef={video} trackRef={video}
// There's no reason for this to be focusable // There's no reason for this to be focusable
tabIndex={-1} tabIndex={-1}
// React supports the disablePictureInPicture attribute, but Firefox disablePictureInPicture
// only recognizes a value of "true", whereas React sets it to the empty
// string. So we need to bypass React and set it specifically to "true".
// https://bugzilla.mozilla.org/show_bug.cgi?id=1865748
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
// eslint-disable-next-line react/no-unknown-property
disablepictureinpicture="true"
/> />
)} )}
</div> </div>