Fix jumpy speaker tiles in spotlight mode

reorderTiles was programmed to only place a tile in the speaker section if that tile's previous position was off-screen. But for speakers that started off-screen, this would cause them to oscillate in and out of the speaker section on each render, because the speaker section is, of course, on-screen. The solution I've gone with here is to avoid referencing the previous position, and instead go by the computed natural ordering, which ought to be more stable.
This commit is contained in:
Robin
2023-11-20 00:29:15 -05:00
parent 85250e6ea3
commit 42c8677be1
2 changed files with 91 additions and 8 deletions

View File

@@ -54,7 +54,7 @@ interface TilePosition {
zIndex: number;
}
interface Tile<T> {
export interface Tile<T> {
key: string;
order: number;
item: TileDescriptor<T>;
@@ -728,7 +728,7 @@ function displayedTileCount(
// Sets the 'order' property on tiles based on the layout param and
// other properties of the tiles, eg. 'focused' and 'presenter'
function reorderTiles<T>(
export function reorderTiles<T>(
tiles: Tile<T>[],
layout: Layout,
displayedTile = -1,
@@ -750,7 +750,6 @@ function reorderTiles<T>(
} else {
const focusedTiles: Tile<T>[] = [];
const presenterTiles: Tile<T>[] = [];
const speakerTiles: Tile<T>[] = [];
const onlyVideoTiles: Tile<T>[] = [];
const otherTiles: Tile<T>[] = [];
@@ -763,8 +762,6 @@ function reorderTiles<T>(
focusedTiles.push(tile);
} else if (tile.isPresenter) {
presenterTiles.push(tile);
} else if (tile.isSpeaker && displayedTile < tile.order) {
speakerTiles.push(tile);
} else if (tile.hasVideo) {
if (tile.order === 0 && tile.item.local) {
firstLocalTile = tile;
@@ -788,13 +785,27 @@ function reorderTiles<T>(
}
}
[
const reorderedTiles = [
...focusedTiles,
...presenterTiles,
...speakerTiles,
...onlyVideoTiles,
...otherTiles,
].forEach((tile, i) => (tile.order = i));
];
let nextSpeakerTileIndex = focusedTiles.length + presenterTiles.length;
reorderedTiles.forEach((tile, i) => {
// If a speaker's natural ordering would place it outside the default
// visible area, promote them to the section dedicated to speakers
if (tile.isSpeaker && displayedTile <= i && nextSpeakerTileIndex < i) {
// Remove the tile from its current section
reorderedTiles.splice(i, 1);
// Insert it into the speaker section
reorderedTiles.splice(nextSpeakerTileIndex, 0, tile);
nextSpeakerTileIndex++;
}
});
reorderedTiles.forEach((tile, i) => (tile.order = i));
}
}