From b5f6343a5e906f4dd34e31e52f41603f7bf4aa35 Mon Sep 17 00:00:00 2001 From: Robin Date: Tue, 9 Jul 2024 11:54:13 -0400 Subject: [PATCH] Remove ResizeObserver polyfill All major browsers support it out of the box, nowadays. --- package.json | 1 - src/room/VideoPreview.tsx | 3 +-- vite.config.js | 1 - yarn.lock | 5 ----- 4 files changed, 1 insertion(+), 9 deletions(-) diff --git a/package.json b/package.json index 4e2c2ac2..690f2723 100644 --- a/package.json +++ b/package.json @@ -19,7 +19,6 @@ "backend": "docker-compose -f backend-docker-compose.yml up" }, "dependencies": { - "@juggle/resize-observer": "^3.3.1", "@livekit/components-core": "^0.11.0", "@livekit/components-react": "^2.0.0", "@opentelemetry/api": "^1.4.0", diff --git a/src/room/VideoPreview.tsx b/src/room/VideoPreview.tsx index 5899a8bf..6a10c682 100644 --- a/src/room/VideoPreview.tsx +++ b/src/room/VideoPreview.tsx @@ -16,7 +16,6 @@ limitations under the License. import { useEffect, useMemo, useRef, FC, ReactNode, useCallback } from "react"; import useMeasure from "react-use-measure"; -import { ResizeObserver } from "@juggle/resize-observer"; import { usePreviewTracks } from "@livekit/components-react"; import { LocalVideoTrack, Track } from "livekit-client"; import classNames from "classnames"; @@ -51,7 +50,7 @@ export const VideoPreview: FC = ({ muteStates, children, }) => { - const [previewRef, previewBounds] = useMeasure({ polyfill: ResizeObserver }); + const [previewRef, previewBounds] = useMeasure(); const devices = useMediaDevices(); diff --git a/vite.config.js b/vite.config.js index cad583da..adea0d96 100644 --- a/vite.config.js +++ b/vite.config.js @@ -76,7 +76,6 @@ export default defineConfig(({ mode }) => { "react-dom", "matrix-js-sdk", "react-use-measure", - "@juggle/resize-observer", // These packages modify the document based on some module-level global // state, and don't play nicely with duplicate copies of themselves // https://github.com/radix-ui/primitives/issues/1241#issuecomment-1847837850 diff --git a/yarn.lock b/yarn.lock index e01d496c..9e16c83d 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1870,11 +1870,6 @@ "@jridgewell/resolve-uri" "^3.1.0" "@jridgewell/sourcemap-codec" "^1.4.14" -"@juggle/resize-observer@^3.3.1": - version "3.4.0" - resolved "https://registry.yarnpkg.com/@juggle/resize-observer/-/resize-observer-3.4.0.tgz#08d6c5e20cf7e4cc02fd181c4b0c225cd31dbb60" - integrity sha512-dfLbk+PwWvFzSxwk3n5ySL0hfBog779o8h68wK/7/APo/7cgyWp5jcXockbxdk5kFRkbeXWm4Fbi9FrdN381sA== - "@livekit/components-core@0.11.2", "@livekit/components-core@^0.11.0": version "0.11.2" resolved "https://registry.yarnpkg.com/@livekit/components-core/-/components-core-0.11.2.tgz#fded2e207155e4737ed52830d48b75ae2eaaf449"