Upgrade eslint-plugin-matrix-org to 1.2.1

This upgrade came with a number of new lints that needed to be fixed across the code base. Primarily: explicit return types on functions, and explicit visibility modifiers on class members.

src/settings/SettingsModal.tsx

@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-import { ChangeEvent, Key, useCallback, useState } from "react";
+import { ChangeEvent, FC, Key, ReactNode, useCallback, useState } from "react";
 import { Item } from "@react-stately/collections";
 import { Trans, useTranslation } from "react-i18next";
 import { MatrixClient } from "matrix-js-sdk";
@@ -59,7 +59,7 @@ interface Props {
   defaultTab?: string;
 }
 
-export const SettingsModal = (props: Props) => {
+export const SettingsModal: FC<Props> = (props) => {
   const { t } = useTranslation();
 
   const [showInspector, setShowInspector] = useShowInspector();
@@ -73,7 +73,10 @@ export const SettingsModal = (props: Props) => {
   const downloadDebugLog = useDownloadDebugLog();
 
   // Generate a `SelectInput` with a list of devices for a given device kind.
-  const generateDeviceSelection = (devices: MediaDevice, caption: string) => {
+  const generateDeviceSelection = (
+    devices: MediaDevice,
+    caption: string
+  ): ReactNode => {
     if (devices.available.length == 0) return null;
 
     return (
@@ -84,7 +87,7 @@ export const SettingsModal = (props: Props) => {
             ? "default"
             : devices.selectedId
         }
-        onSelectionChange={(id) => devices.select(id.toString())}
+        onSelectionChange={(id): void => devices.select(id.toString())}
       >
         {devices.available.map(({ deviceId, label }, index) => (
           <Item key={deviceId}>
@@ -197,7 +200,7 @@ export const SettingsModal = (props: Props) => {
           checked={developerSettingsTab}
           label={t("Developer Settings")}
           description={t("Expose developer settings in the settings window.")}
-          onChange={(event: ChangeEvent<HTMLInputElement>) =>
+          onChange={(event: ChangeEvent<HTMLInputElement>): void =>
             setDeveloperSettingsTab(event.target.checked)
           }
         />
@@ -209,7 +212,7 @@ export const SettingsModal = (props: Props) => {
           type="checkbox"
           checked={optInAnalytics ?? undefined}
           description={optInDescription}
-          onChange={(event: ChangeEvent<HTMLInputElement>) => {
+          onChange={(event: ChangeEvent<HTMLInputElement>): void => {
             setOptInAnalytics?.(event.target.checked);
           }}
         />
@@ -241,7 +244,7 @@ export const SettingsModal = (props: Props) => {
           label={t("Show call inspector")}
           type="checkbox"
           checked={showInspector}
-          onChange={(e: ChangeEvent<HTMLInputElement>) =>
+          onChange={(e: ChangeEvent<HTMLInputElement>): void =>
             setShowInspector(e.target.checked)
           }
         />
@@ -253,7 +256,7 @@ export const SettingsModal = (props: Props) => {
           label={t("Show connection stats")}
           type="checkbox"
           checked={showConnectionStats}
-          onChange={(e: ChangeEvent<HTMLInputElement>) =>
+          onChange={(e: ChangeEvent<HTMLInputElement>): void =>
             setShowConnectionStats(e.target.checked)
           }
         />
@@ -270,7 +273,7 @@ export const SettingsModal = (props: Props) => {
           disabled={!setEnableE2EE}
           type="checkbox"
           checked={enableE2EE ?? undefined}
-          onChange={(e: ChangeEvent<HTMLInputElement>) =>
+          onChange={(e: ChangeEvent<HTMLInputElement>): void =>
             setEnableE2EE?.(e.target.checked)
           }
         />