Hide connection quality indicators behind a developer setting

Calls are an environment with high cognitive load, so it's important that we keep extra UI elements like these to a minimum and stick to what's been explicitly designed. I assume that this was here as a developer feature to diagnose reliability of the back end components, which is perfectly fine, so I've kept it behind a developer setting rather than fully removing it.
This commit is contained in:
Robin Townsend
2023-06-16 10:59:57 -04:00
parent 4342f4b027
commit a96d70eefb
5 changed files with 31 additions and 2 deletions

View File

@@ -54,7 +54,10 @@ import {
useVideoGridLayout,
TileDescriptor,
} from "../video-grid/VideoGrid";
import { useShowInspector } from "../settings/useSetting";
import {
useShowInspector,
useShowConnectionStats,
} from "../settings/useSetting";
import { useModalTriggerState } from "../Modal";
import { PosthogAnalytics } from "../analytics/PosthogAnalytics";
import { useUrlParams } from "../UrlParams";
@@ -189,6 +192,7 @@ export function InCallView({
);
const [showInspector] = useShowInspector();
const [showConnectionStats] = useShowConnectionStats();
const { hideScreensharing } = useUrlParams();
@@ -290,6 +294,7 @@ export function InCallView({
key={maximisedParticipant.id}
data={maximisedParticipant.data}
showSpeakingIndicator={false}
showConnectionStats={showConnectionStats}
/>
);
}
@@ -303,6 +308,7 @@ export function InCallView({
{(props) => (
<VideoTile
showSpeakingIndicator={items.length > 2}
showConnectionStats={showConnectionStats}
{...props}
ref={props.ref as Ref<HTMLDivElement>}
/>