From aac92c18b3075ef233e68990188f860f37a6b370 Mon Sep 17 00:00:00 2001 From: David Baker Date: Fri, 13 Oct 2023 11:02:20 +0100 Subject: [PATCH] Re-enable screen sharing on Safari Appears to work fine now, and no reason to think it shouldn't on Livekit. --- src/room/InCallView.tsx | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/room/InCallView.tsx b/src/room/InCallView.tsx index 9dc124f9..bd0fd1a7 100644 --- a/src/room/InCallView.tsx +++ b/src/room/InCallView.tsx @@ -87,9 +87,6 @@ import { import { useOpenIDSFU } from "../livekit/openIDSFU"; const canScreenshare = "getDisplayMedia" in (navigator.mediaDevices ?? {}); -// There is currently a bug in Safari our our code with cloning and sending MediaStreams -// or with getUsermedia and getDisplaymedia being used within the same session. -// For now we can disable screensharing in Safari. const isSafari = /^((?!chrome|android).)*safari/i.test(navigator.userAgent); // How long we wait after a focus switch before showing the real participant list again @@ -369,7 +366,7 @@ export const InCallView: FC = ({ ); if (!reducedControls) { - if (canScreenshare && !hideScreensharing && !isSafari) { + if (canScreenshare && !hideScreensharing) { buttons.push(