Fix lint errors
Various hooks either missing dependencies or with extra ones. Two remaining errors are from the recapcta code where I can't work out if the extra dependency is intentional or not.
This commit is contained in:
@@ -86,7 +86,7 @@ export function useLoadGroupCall(client, roomId, viaServers, createIfNotFound) {
|
||||
.catch((error) =>
|
||||
setState((prevState) => ({ ...prevState, loading: false, error }))
|
||||
);
|
||||
}, [client, roomId, state.reloadId]);
|
||||
}, [client, roomId, state.reloadId, createIfNotFound, viaServers]);
|
||||
|
||||
return state;
|
||||
}
|
||||
|
||||
@@ -55,7 +55,7 @@ export function usePTT(client, groupCall, userMediaFeeds) {
|
||||
|
||||
setState((prevState) => ({ ...prevState, pttButtonHeld: true }));
|
||||
}
|
||||
}, []);
|
||||
}, [groupCall, activeSpeakerUserId, isAdmin, talkOverEnabled]);
|
||||
|
||||
const stopTalking = useCallback(() => {
|
||||
if (!groupCall.isMicrophoneMuted()) {
|
||||
@@ -63,7 +63,7 @@ export function usePTT(client, groupCall, userMediaFeeds) {
|
||||
}
|
||||
|
||||
setState((prevState) => ({ ...prevState, pttButtonHeld: false }));
|
||||
}, []);
|
||||
}, [groupCall]);
|
||||
|
||||
useEffect(() => {
|
||||
function onKeyDown(event) {
|
||||
@@ -100,7 +100,14 @@ export function usePTT(client, groupCall, userMediaFeeds) {
|
||||
window.removeEventListener("keyup", onKeyUp);
|
||||
window.removeEventListener("blur", onBlur);
|
||||
};
|
||||
}, [activeSpeakerUserId, isAdmin, talkOverEnabled]);
|
||||
}, [
|
||||
groupCall,
|
||||
startTalking,
|
||||
stopTalking,
|
||||
activeSpeakerUserId,
|
||||
isAdmin,
|
||||
talkOverEnabled,
|
||||
]);
|
||||
|
||||
const setTalkOverEnabled = useCallback((talkOverEnabled) => {
|
||||
setState((prevState) => ({
|
||||
|
||||
Reference in New Issue
Block a user