From d062871f41e29e2c103dae305b24f1e02c09a677 Mon Sep 17 00:00:00 2001
From: Robin <robin@robin.town>
Date: Fri, 26 Jul 2024 05:27:22 -0400
Subject: [PATCH] Don't consider microphone mute state in importance ordering
 (#2515)

We're finding that if we reorder participants based on whether their mic is muted, this just creates a lot of distracting layout shifts. People who speak are automatically promoted into the speaker category, so there's little value in additionally caring about mute state.
---
 src/state/CallViewModel.ts | 22 ++++++----------------
 1 file changed, 6 insertions(+), 16 deletions(-)

diff --git a/src/state/CallViewModel.ts b/src/state/CallViewModel.ts
index 54029b0b..35290140 100644
--- a/src/state/CallViewModel.ts
+++ b/src/state/CallViewModel.ts
@@ -150,21 +150,13 @@ enum SortingBin {
    */
   Speakers,
   /**
-   * Participants with both video and audio.
-   */
-  VideoAndAudio,
-  /**
-   * Participants with video but no audio.
+   * Participants with video.
    */
   Video,
   /**
-   * Participants with audio but no video.
+   * Participants not sharing any video.
    */
-  Audio,
-  /**
-   * Participants not sharing any media.
-   */
-  NoMedia,
+  NoVideo,
   /**
    * Yourself, when the "always show self" option is off.
    */
@@ -457,13 +449,12 @@ export class CallViewModel extends ViewModel {
           [
             m.speaker,
             m.presenter,
-            m.vm.audioEnabled,
             m.vm.videoEnabled,
             m.vm instanceof LocalUserMediaViewModel
               ? m.vm.alwaysShow
               : of(false),
           ],
-          (speaker, presenter, audio, video, alwaysShow) => {
+          (speaker, presenter, video, alwaysShow) => {
             let bin: SortingBin;
             if (m.vm.local)
               bin = alwaysShow
@@ -471,9 +462,8 @@ export class CallViewModel extends ViewModel {
                 : SortingBin.SelfNotAlwaysShown;
             else if (presenter) bin = SortingBin.Presenters;
             else if (speaker) bin = SortingBin.Speakers;
-            else if (video)
-              bin = audio ? SortingBin.VideoAndAudio : SortingBin.Video;
-            else bin = audio ? SortingBin.Audio : SortingBin.NoMedia;
+            else if (video) bin = SortingBin.Video;
+            else bin = SortingBin.NoVideo;
 
             return [m, bin] as const;
           },