Commit Graph

1428 Commits

Author SHA1 Message Date
Robin Townsend
1c6ef97457 Improve typing around layouts and grid components 2023-06-28 10:59:36 -04:00
Robin Townsend
cc35f243f2 Make NewVideoGrid support arbitrary layout systems
In preparation for adding layouts other than big grid to the NewVideoGrid component, I've abstracted the grid layout system into an interface called Layout. For now, the only implementation of this interface is BigGrid, but this will allow us to easily plug in Spotlight, SplitGrid, and OneOnOne layout systems so we can get rid of the old VideoGrid component and have One Grid to Rule Them All™.

Please do shout if any of this seems obtuse or underdocumented, because I'm not super happy with how approachable the NewVideoGrid code looks right now…

Incidentally, this refactoring made it way easier to save the state of the grid while in fullscreen / another layout, so I went ahead and did that.
2023-06-27 14:20:45 -04:00
Šimon Brandner
3a2cee581e Get LK info from the js-sdk
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2023-06-27 17:28:50 +02:00
Robin
e625894ae9 Merge pull request #1146 from robintown/fullscreen-and-pip
Bring back fullscreen and picture-in-picture modes
2023-06-27 09:22:19 -04:00
David Baker
2caaa15520 Fix username / displayname naming confusion 2023-06-27 12:23:19 +01:00
Robin Townsend
276684c103 Bring back fullscreen and picture-in-picture modes
We're now using LiveKit's magic RoomAudioRenderer component to make sure everyone's audio is rendered regardless of whether they have a tile in the DOM.
2023-06-26 13:48:41 -04:00
Robin Townsend
25eb56418d Show the room avatar rather than the user avatar in the header
It's supposed to be the room avatar; this was a regression introduced during the LiveKit hack week.
2023-06-23 16:20:15 -04:00
Robin
f08facbff3 Merge pull request #1135 from robintown/embedded-device-selection
Fix device selection never completing in widget mode
2023-06-23 15:02:30 -04:00
Robin Townsend
c181d250ac Note the call backend in rageshake and analytics data 2023-06-23 14:47:32 -04:00
Robin Townsend
45915ed67e Fix device selection never completing in widget mode
By reinstating some of the code from the full mesh branch that was there to handle this
2023-06-23 14:17:51 -04:00
Enrico Schwendig
6dbfb289eb Local user should never be in the spotlight (#1125)
* Local user should never be in spotlight
2023-06-21 14:51:41 +02:00
Robin Townsend
7bb45adbe1 Fix lint 2023-06-20 12:13:27 -04:00
Robin Townsend
510d55d88a Fix local tile showing as unmuted when you join muted 2023-06-18 14:28:28 -04:00
Robin Townsend
eb500ed88e Skip an unnecessary render when calculating display names 2023-06-18 14:28:07 -04:00
Robin Townsend
a2c40561db Fix a likely bug with audio inputs and outputs getting mixed up? 2023-06-18 14:26:50 -04:00
Robin Townsend
fc307d0aba Don't show ghost tiles while connecting 2023-06-18 14:26:27 -04:00
Robin Townsend
65f390e2e5 Merge branch 'grid-interactions' into livekit-experiment 2023-06-18 11:45:43 -04:00
Robin Townsend
cd7ab00d80 Don't try to promote the same speaker multiple times 2023-06-18 11:45:01 -04:00
Robin Townsend
ae5b1a367d Merge branch 'grid-interactions' into livekit-experiment 2023-06-18 11:36:59 -04:00
Robin Townsend
ddeb36db47 Promote speakers to the first page of the grid 2023-06-18 11:35:13 -04:00
Robin Townsend
c3c26e235b Merge branch 'grid-interactions' into livekit-experiment 2023-06-18 01:13:45 -04:00
Robin Townsend
4e5a75074a Fix tiles not collapsing toward their center 2023-06-18 01:01:24 -04:00
Robin Townsend
391ba5196c Make screenshares appear near the presenter's tile and be larger 2023-06-18 00:47:37 -04:00
Robin Townsend
3e56d0a656 Make it possible again to drag a tile into the top left corner 2023-06-18 00:28:08 -04:00
Robin Townsend
d1e7d963a3 Merge branch 'grid-interactions' into livekit-experiment 2023-06-17 22:32:19 -04:00
Robin Townsend
afbcea7b66 Allow the grid to resize with the window width 2023-06-17 22:31:07 -04:00
Robin Townsend
4f582c6ad7 Don't change tile size when dragging 2023-06-17 22:31:07 -04:00
Robin Townsend
8b8d6fd0e0 Push large tiles upwards back into the grid 2023-06-17 22:31:01 -04:00
Enrico Schwendig
f13c0f07cc Spotlite tile order (#1118)
* Manage spotlight tile slots for speaker and presenter
2023-06-16 18:57:47 +02:00
Robin Townsend
7f5ec069a5 Merge branch 'main' into livekit-experiment 2023-06-16 12:57:06 -04:00
Robin
4fd1264d12 Merge pull request #1123 from robintown/connection-indicators
Hide connection quality indicators behind a developer setting
2023-06-16 12:56:36 -04:00
Daniel Abramov
5b4787cef6 LiveKit Device Usage Refactoring (#1120)
Signed-off-by: Timo K <toger5@hotmail.de>
Co-authored-by: Timo K <toger5@hotmail.de>
2023-06-16 18:07:13 +02:00
Robin Townsend
a96d70eefb Hide connection quality indicators behind a developer setting
Calls are an environment with high cognitive load, so it's important that we keep extra UI elements like these to a minimum and stick to what's been explicitly designed. I assume that this was here as a developer feature to diagnose reliability of the back end components, which is perfectly fine, so I've kept it behind a developer setting rather than fully removing it.
2023-06-16 10:59:57 -04:00
Robin Townsend
1b3539e873 Fix speaking indicators showing up when they shouldn't
This fixes two edge cases:

- Screenshares should never have a speaking indicator
- Speaking indicators should be hidden in 1:1 calls
2023-06-16 10:35:29 -04:00
Robin Townsend
f4f454f58e Improve the performance of dragging tiles in the large grid
By only updating the one spring of the tile that's being interacted with
2023-06-16 10:20:24 -04:00
Timo K
86ab2b4287 tinyFixes
Signed-off-by: Timo K <toger5@hotmail.de>
2023-06-15 11:40:16 +02:00
Timo K
a01e62d9ed revert of combined video+audio permission request
Signed-off-by: Timo K <toger5@hotmail.de>
2023-06-15 11:36:39 +02:00
Timo
160d1f23a9 fi Crash if no device is available (#1116)
Signed-off-by: Timo K <toger5@hotmail.de>
2023-06-15 00:06:51 +02:00
Daniel Abramov
0445c47c02 Merge branch 'livekit-experiment' into livekit-load-test 2023-06-14 22:14:06 +02:00
Daniel Abramov
520f241efa Merge branch 'livekit-experiment' into livekit-load-test 2023-06-14 21:12:20 +02:00
Timo
41f2728724 Device from lobby to call (#1110)
* respect mute state set in lobby for call

Signed-off-by: Timo K <toger5@hotmail.de>

* move device from lobby to call

Signed-off-by: Timo K <toger5@hotmail.de>

* save device in local storage

Signed-off-by: Timo K <toger5@hotmail.de>

* local storage + fixes

Signed-off-by: Timo K <toger5@hotmail.de>

* device permissions

Signed-off-by: Timo K <toger5@hotmail.de>

---------

Signed-off-by: Timo K <toger5@hotmail.de>
2023-06-14 19:20:53 +02:00
Robin
89768de5e0 Merge pull request #1114 from robintown/screenshare-tiles
Fix tiles having the wrong states during screensharing
2023-06-14 12:01:23 -04:00
Robin Townsend
037495a635 Fix tiles having the wrong states during screensharing
This fixes a couple bugs:

1. That muting your video while screensharing would cause the screensharing feed to be hidden as well
2. That while screensharing, your user media tile would incorrectly show the label that's supposed to appear only on the screenshare tile
2023-06-14 11:55:43 -04:00
Robin Townsend
357e1f828a Fix spotlight layout 2023-06-14 11:37:07 -04:00
Enrico Schwendig
20c9c09258 Build EC room use method (#1108)
* Build custom useRoom
2023-06-14 15:03:38 +02:00
David Baker
30e1034fba Use new-js-sdk flag to disable the actual calling of group calls
In favour of using livekit
2023-06-14 12:13:55 +01:00
Robin Townsend
2916eb45aa Switch to the new grid once there are >12 participants 2023-06-13 12:54:24 -04:00
Robin Townsend
4d5c3cd773 Merge branch 'main' into livekit-experiment 2023-06-13 12:33:46 -04:00
Daniel Abramov
556c46320d Merge branch 'livekit-experiment' into livekit-load-test 2023-06-13 17:24:15 +02:00
Daniel Abramov
6436e66adb Merge branch 'livekit-experiment' into livekit-load-test 2023-06-13 17:23:42 +02:00