Commit Graph

29 Commits

Author SHA1 Message Date
David Baker
ea1c2e9ec3 Merge remote-tracking branch 'origin/livekit' into dbkr/remove_e2ee_setting 2023-10-13 15:26:30 +01:00
David Baker
5ef208e789 Remove E2EE setting
Since e2ee is enabled by default now
2023-10-13 10:30:06 +01:00
David Baker
d058f08c47 Prettier 2023-10-11 16:25:47 +01:00
David Baker
9d4ade97b0 Remove redundant check
Co-authored-by: Timo <16718859+toger5@users.noreply.github.com>
2023-10-11 16:10:03 +01:00
Robin
614bc82402 Format code 2023-10-11 10:42:04 -04:00
David Baker
6039253a32 Reafctor a bit 2023-10-11 12:53:33 +01:00
David Baker
51f87fa42a Add comment
Co-authored-by: Timo <16718859+toger5@users.noreply.github.com>
2023-10-10 17:06:49 +01:00
David Baker
d7b33ee959 Always store room passwords with the right room ID
Take the room ID from the URL rather than just assuming it's still
the one that was in URL params before: if only the hash changes,
the app won't reload.

Fixes https://github.com/vector-im/element-call/issues/1708
2023-10-09 17:43:50 +01:00
David Baker
b646b0ae56 Remove extra function
that was now doing exactly the same thing as the one above it.
2023-10-05 17:25:06 +01:00
David Baker
4984bd630e Keep the password in the URL
We changed our minds: people do copy the URL from the bar and
give that to people and expect it to work: it doesn't make sense
to prioritise shorter URLs over this. There's no security advantage
unless we think there's a risk someone might steal your key by taking
a photo of your monitor over your shoulder and decrypting the calls
they can't already hear by standing behind you.
2023-10-05 16:13:56 +01:00
David Baker
48b038914f Revert "Refactor useIsRoomE2EE" 2023-09-22 18:20:29 +01:00
David Baker
f05cae71a8 Use consistent import 2023-09-22 18:05:51 +01:00
David Baker
3cd0ca205b Refactor useIsRoomE2EE
Make it take a room object rather than a room ID to avoid it depending
on a side effect, ie. if the room object input changes, the hook will be
re-run but if we can't get the room from the room ID for whatever reason,
we'd be stuck.

Also add logging on why we decided a room was e2ee.
2023-09-22 15:35:03 +01:00
David Baker
a5131be7c7 Merge pull request #1557 from vector-im/dbkr/fix_password_race
Fix race where app would be opened with no e2ee key
2023-09-20 18:42:35 +01:00
David Baker
cbf27fc887 Also use return value password in the other hook 2023-09-20 17:40:37 +01:00
David Baker
ed0059c898 Hopefully actually fix password bug 2023-09-20 17:05:10 +01:00
David Baker
96c6217a83 Fix race where app would be opened with no e2ee key
The key hadn't been extractwed from the URL at the point the modal
was mounted, so it just didn't get the key.
2023-09-20 16:25:02 +01:00
Timo
5c377ba01d Dont ignore rest of url (#1555)
Signed-off-by: Timo K <toger5@hotmail.de>
2023-09-20 16:26:09 +02:00
Robin
4253963b95 Untangle the semantics of isEmbedded
This deletes the isEmbedded flag from UrlParams, replacing it with an alternative set of flags that I think is more sensible and well-defined.
2023-09-18 21:00:18 -04:00
Šimon Brandner
9d142c1ea5 Fix useIsRoomE2EE()
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2023-08-25 15:30:58 +02:00
Šimon Brandner
d0fe055af6 Always allow setting a password
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2023-08-16 15:39:55 +02:00
Šimon Brandner
3ea908c59f Revert "Remove optional call"
This reverts commit 74c70627dc.
2023-08-16 15:38:23 +02:00
Šimon Brandner
74c70627dc Remove optional call
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2023-08-16 15:35:49 +02:00
Šimon Brandner
54157611eb Remove log line
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2023-08-16 13:56:31 +02:00
Šimon Brandner
edfae0138c Add useIsRoomE2EE()
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2023-08-11 16:59:26 +02:00
Šimon Brandner
e246c053c1 Improve loading of passwords
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2023-08-11 16:57:55 +02:00
Šimon Brandner
935d2188f0 Do not allow joining a call without E2EE key
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2023-08-09 14:01:36 +02:00
Šimon Brandner
c4e5e1afb1 Save room shared keys to local storage
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2023-08-09 14:01:36 +02:00
Šimon Brandner
8fdc1e3684 Store shared keys in local storage
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2023-08-09 14:01:34 +02:00