169ccd9de5
As Element Call grows in complexity, it has become a pain point that our business logic remains so tightly coupled to the UI code. In particular, this has made testing difficult, and the complex semantics of React hooks are not a great match for arbitrary business logic. Here, I show the beginnings of what it would look like for us to adopt the MVVM pattern. I've created a CallViewModel and TileViewModel that expose their state to the UI as rxjs Observables, as well as a couple of helper functions for consuming view models in React code. This should contain no user-visible changes, but we need to watch out for regressions particularly around focus switching and promotion of speakers, because this was the logic I chose to refactor first.
96 lines
2.4 KiB
TypeScript
96 lines
2.4 KiB
TypeScript
/*
|
|
Copyright 2022 - 2023 New Vector Ltd
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
import { ChangeEvent, FC, useState } from "react";
|
|
import { useTranslation } from "react-i18next";
|
|
import { RemoteParticipant, Track } from "livekit-client";
|
|
|
|
import { FieldRow } from "../input/Input";
|
|
import { Modal } from "../Modal";
|
|
import styles from "./VideoTileSettingsModal.module.css";
|
|
import { VolumeIcon } from "../button/VolumeIcon";
|
|
|
|
interface LocalVolumeProps {
|
|
participant: RemoteParticipant;
|
|
media: "user media" | "screen share";
|
|
}
|
|
|
|
const LocalVolume: FC<LocalVolumeProps> = ({
|
|
participant,
|
|
media,
|
|
}: LocalVolumeProps) => {
|
|
const source =
|
|
media === "user media"
|
|
? Track.Source.Microphone
|
|
: Track.Source.ScreenShareAudio;
|
|
|
|
const [localVolume, setLocalVolume] = useState<number>(
|
|
participant.getVolume(source) ?? 0,
|
|
);
|
|
|
|
const onLocalVolumeChanged = (event: ChangeEvent<HTMLInputElement>): void => {
|
|
const value: number = +event.target.value;
|
|
setLocalVolume(value);
|
|
participant.setVolume(value, source);
|
|
};
|
|
|
|
return (
|
|
<>
|
|
<FieldRow>
|
|
<VolumeIcon volume={localVolume} />
|
|
<input
|
|
className={styles.localVolumeSlider}
|
|
type="range"
|
|
min="0"
|
|
max="1"
|
|
step="0.01"
|
|
value={localVolume}
|
|
onChange={onLocalVolumeChanged}
|
|
/>
|
|
</FieldRow>
|
|
</>
|
|
);
|
|
};
|
|
|
|
interface Props {
|
|
participant: RemoteParticipant;
|
|
media: "user media" | "screen share";
|
|
open: boolean;
|
|
onDismiss: () => void;
|
|
}
|
|
|
|
export const VideoTileSettingsModal: FC<Props> = ({
|
|
participant,
|
|
media,
|
|
open,
|
|
onDismiss,
|
|
}) => {
|
|
const { t } = useTranslation();
|
|
|
|
return (
|
|
<Modal
|
|
className={styles.videoTileSettingsModal}
|
|
title={t("local_volume_label")}
|
|
open={open}
|
|
onDismiss={onDismiss}
|
|
>
|
|
<div className={styles.content}>
|
|
<LocalVolume participant={participant} media={media} />
|
|
</div>
|
|
</Modal>
|
|
);
|
|
};
|